Skip to content

chore: update codecov to 3.8.3 #3813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2021
Merged

chore: update codecov to 3.8.3 #3813

merged 1 commit into from
Jul 20, 2021

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Jul 19, 2021

This PR updates codecov to 3.8.3 which should help with an issue we faced earlier: codecov/codecov-node#324 (comment)

@jsjoeio jsjoeio requested a review from a team as a code owner July 19, 2021 23:03
Copy link
Contributor

@jawnsy jawnsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, had a question about the versions though

resolved "https://registry.yarnpkg.com/codecov/-/codecov-3.8.2.tgz#ab24f18783998c39e809ea210af899f8dbcc790e"
integrity sha512-6w/kt/xvmPsWMfDFPE/T054txA9RTgcJEw36PNa6MYX+YV29jCHCRFXwbQ3QZBTOgnex1J2WP8bo2AT8TWWz9g==
codecov@^3.8.8:
version "3.8.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks kinda weird that the line above says ^3.8.8 but the version installed is 3.8.3?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what the...how does that happen? Let me try running yarn again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic catch btw!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mysteries of Yarn...

shrug gif

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, pushed and will auto-merge!

@jsjoeio jsjoeio force-pushed the jsjoeio-upgrade-codecov-node branch from 99a9010 to 2d022b8 Compare July 19, 2021 23:47
@jsjoeio jsjoeio enabled auto-merge July 19, 2021 23:48
@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #3813 (2d022b8) into main (f96bcdc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3813   +/-   ##
=======================================
  Coverage   62.05%   62.05%           
=======================================
  Files          36       36           
  Lines        1863     1863           
  Branches      378      378           
=======================================
  Hits         1156     1156           
  Misses        601      601           
  Partials      106      106           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f96bcdc...2d022b8. Read the comment docs.

@jsjoeio jsjoeio merged commit 475ae45 into main Jul 20, 2021
@jsjoeio jsjoeio deleted the jsjoeio-upgrade-codecov-node branch July 20, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants