-
Notifications
You must be signed in to change notification settings - Fork 5.9k
chore: update codecov to 3.8.3 #3813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, had a question about the versions though
resolved "https://registry.yarnpkg.com/codecov/-/codecov-3.8.2.tgz#ab24f18783998c39e809ea210af899f8dbcc790e" | ||
integrity sha512-6w/kt/xvmPsWMfDFPE/T054txA9RTgcJEw36PNa6MYX+YV29jCHCRFXwbQ3QZBTOgnex1J2WP8bo2AT8TWWz9g== | ||
codecov@^3.8.8: | ||
version "3.8.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks kinda weird that the line above says ^3.8.8
but the version installed is 3.8.3
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what the...how does that happen? Let me try running yarn
again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fantastic catch btw!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed, pushed and will auto-merge!
99a9010
to
2d022b8
Compare
Codecov Report
@@ Coverage Diff @@
## main #3813 +/- ##
=======================================
Coverage 62.05% 62.05%
=======================================
Files 36 36
Lines 1863 1863
Branches 378 378
=======================================
Hits 1156 1156
Misses 601 601
Partials 106 106 Continue to review full report at Codecov.
|
This PR updates
codecov
to3.8.3
which should help with an issue we faced earlier: codecov/codecov-node#324 (comment)