Skip to content

Fix Docker push #3796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 16, 2021
Merged

Fix Docker push #3796

merged 5 commits into from
Jul 16, 2021

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented Jul 16, 2021

This also makes the publish steps idempotent so we can re-run the publish workflow.

@code-asher code-asher requested a review from a team as a code owner July 16, 2021 22:25
It seems we need to use `docker import` with the output from `docker
buildx` rather than `docker load` like we were doing when we used
`docker save`.
This helps make the publish workflow idempotent.
@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #3796 (9ef6680) into main (52579f1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3796   +/-   ##
=======================================
  Coverage   62.05%   62.05%           
=======================================
  Files          36       36           
  Lines        1863     1863           
  Branches      378      378           
=======================================
  Hits         1156     1156           
  Misses        601      601           
  Partials      106      106           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52579f1...9ef6680. Read the comment docs.

@code-asher code-asher merged commit f720b63 into coder:main Jul 16, 2021
@code-asher code-asher deleted the docker-push branch July 16, 2021 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant