Skip to content

revert: add eslint-import-resolver-alias as dependency #3742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Jul 7, 2021

In #3729, I removed eslint-import-resolver-alias because I didn't think we used it but turns out we do to make importing code-server plugins in a test.

I don't fully understand exactly how it works, but it has to with aliasing a module (code-server itself as a module) in one of our tests. I tried putting it in the test/package.json but ESLint didn't like that.

@jsjoeio jsjoeio self-assigned this Jul 7, 2021
@jsjoeio jsjoeio requested a review from a team as a code owner July 7, 2021 18:12
@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #3742 (9fdf049) into main (002fa08) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3742   +/-   ##
=======================================
  Coverage   61.55%   61.55%           
=======================================
  Files          35       35           
  Lines        1813     1813           
  Branches      365      365           
=======================================
  Hits         1116     1116           
  Misses        588      588           
  Partials      109      109           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 876a800...9fdf049. Read the comment docs.

@jsjoeio jsjoeio enabled auto-merge July 7, 2021 18:42
@jsjoeio jsjoeio disabled auto-merge July 7, 2021 18:42
@jsjoeio jsjoeio merged commit a465af1 into main Jul 7, 2021
@jsjoeio jsjoeio deleted the jsjoeio-fix-missing-dep branch July 7, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant