Skip to content

feat(test): try calling .dispose() x2 in emitter #3713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2021
Merged

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Jul 2, 2021

This adds a couple lines to hit 100% test coverage for emitter.ts by ensuring that our logic works when trying to dispose of a callback more than once.

image

Fixes N/A

@jsjoeio jsjoeio requested a review from a team as a code owner July 2, 2021 21:28
@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #3713 (f3c4dcd) into main (58514c4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3713   +/-   ##
=======================================
  Coverage   61.55%   61.55%           
=======================================
  Files          35       35           
  Lines        1813     1813           
  Branches      365      365           
=======================================
  Hits         1116     1116           
  Misses        588      588           
  Partials      109      109           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58514c4...f3c4dcd. Read the comment docs.

@jsjoeio jsjoeio enabled auto-merge July 2, 2021 21:34
@jsjoeio jsjoeio merged commit b365830 into main Jul 2, 2021
@jsjoeio jsjoeio deleted the jsjoeio-test-emitter branch July 2, 2021 21:44
@jsjoeio jsjoeio self-assigned this Jul 2, 2021
@jsjoeio jsjoeio added the testing Anything related to testing label Jul 2, 2021
@jsjoeio jsjoeio added this to the 3.11.0 milestone Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants