Skip to content

Fix broken link on docs site #3692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Fix broken link on docs site #3692

merged 1 commit into from
Jun 29, 2021

Conversation

elliott-king
Copy link
Contributor

Links don't work on docs site unless they have md formatting. Fix is minor.

Links don't work on docs site unless they have md formatting.
@elliott-king elliott-king requested a review from a team as a code owner June 29, 2021 20:44
Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think GitHub renders links without the brackets necessary, but our docs engine site does not.

@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #3692 (33dbb7b) into main (6dbabc0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3692   +/-   ##
=======================================
  Coverage   60.13%   60.13%           
=======================================
  Files          35       35           
  Lines        1811     1811           
  Branches      365      365           
=======================================
  Hits         1089     1089           
  Misses        606      606           
  Partials      116      116           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dbabc0...33dbb7b. Read the comment docs.

@jsjoeio jsjoeio self-assigned this Jun 29, 2021
@jsjoeio jsjoeio added the docs Documentation related label Jun 29, 2021
@jsjoeio jsjoeio added this to the 3.11.0 milestone Jun 29, 2021
@jsjoeio jsjoeio enabled auto-merge June 29, 2021 20:52
@jsjoeio jsjoeio added the new contributor For PRs by first-time contributor label Jun 29, 2021
@repo-ranger
Copy link
Contributor

repo-ranger bot commented Jun 29, 2021

Thanks for making your first contribution! 🙂

@jsjoeio jsjoeio merged commit df814aa into coder:main Jun 29, 2021
@jsjoeio
Copy link
Contributor

jsjoeio commented Jun 29, 2021

Thanks for the fix @elliott-king 🎉

@elliott-king elliott-king deleted the patch-1 branch June 30, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related new contributor For PRs by first-time contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants