Parallel tests #3664
Merged
Parallel tests #3664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-asher
force-pushed
the
parallel-tests
branch
from
20ab0f7 to
2a515a0
Compare
Codecov Report
@@ Coverage Diff @@
## main #3664 +/- ##
==========================================
+ Coverage 59.87% 60.13% +0.25%
==========================================
Files 35 35
Lines 1797 1811 +14
Branches 364 365 +1
==========================================
+ Hits 1076 1089 +13
- Misses 605 606 +1
Partials 116 116
Continue to review full report at Codecov.
|
code-asher
force-pushed
the
parallel-tests
branch
9 times, most recently
from
7e0753e to
020d41a
Compare
code-asher
force-pushed
the
parallel-tests
branch
3 times, most recently
from
387a342 to
268dc84
Compare
jsjoeio
suggested changes
Jun 28, 2021
jsjoeio
approved these changes
Jun 29, 2021
The workspaces also have settings to prevent the welcome page from appearing.
This should simplify testing new utils a bit.
This way it can be used by the tests when spawning code-server on a random port to look for the address.
This uses the current dev build by default but can be overidden with CODE_SERVER_TEST_ENTRY (for example to test a release or some other version). Each instance has a separate state directory. This should make parallelization work. This also means you are no longer required to specify the password and address yourself (or the extension directory once we add a test extension). `yarn test:e2e` should just work as-is. Lastly, it means the tests are no longer subject to yarn watch randomly restarting.
My thinking is that this may reduce the cognitive overhead for developers writing new test suites. This also allows us to perform different setup steps (like ensuring the editor is visible when authenticated).
I figure login is already tested so we can skip this and just use the cookie.
It seems a dialog sometimes appears asking if you want to lose changes (even though we have no changes; it seems based on timers in some way). Playwright defaults to dismissing them (so quickly you might not even see them) so accepting instead fixes navigation to the logout page getting canceled.
code-asher
force-pushed
the
parallel-tests
branch
from
daddd0c to
2238d73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recommend reviewing by commit (and reading the commit messages).
Setting as a draft until I'm sure the tests pass in CI.
Checklist
CHANGELOG.md