Fix/issue #286 #365
Fix/issue #286 #365
Conversation
|
We should handle |
|
@code-asher is right. According to |
| for (let i = 2; i < process.argv.length; i++) { | ||
| if (process.argv[i].startsWith("--password=")) { | ||
| parts.push(process.argv[i].replace(/=.*/, "=****")); | ||
| } else if (process.argv[i] === "--password") { |
There was a problem hiding this comment.
My bad, I didn't include -P in my example but we'll need that as well. No need to check for -P= though since = isn't used with short options.
| parts.push(process.argv[i].replace(/=.*/, "=****")); | ||
| } else if (process.argv[i] === "--password") { | ||
| parts.push(process.argv[i++], "****") | ||
| } else if (process.argv[i] === "--") { |
There was a problem hiding this comment.
Another unfortunate edge case comes to mind:
code-server --data-dir -- password pass
That is, -- is only interpreted as the end of options if it isn't the argument for another option.
There was a problem hiding this comment.
It's possible we should use an environment variable and/or configuration file instead of a command line argument for the password. Or possibly a prompt, although I'm not really keen on that solution.
There was a problem hiding this comment.
I believe we have another issue for that #349
|
We should probably use an environment variable and deprecate the usage via CLI. |
|
Using an ENV password will make this PR obsolete. I'll go ahead and close this PR. |
Problem: CLI Password argument is visible in
ps -axIssue: #286
Changes: Adds script to change the process display name.
Test Environment:
OS: Mac OS High Sierra (10.13.6)
Browser: Google Chrome 72.0.3626.109 (Official Build) (64-bit)
(Result: Pass! Compile was successful and everything functions as expected)