Skip to content

Add higher quality Discord badge and add a link to the license badge. #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2019

Conversation

NGTmeaty
Copy link
Contributor

Describe in detail the problem you had and how this PR fixes it

The discord badge wasn't at a high enough quality. This changes it to a version by Shields. I've also linked our MIT license.

Is there an open issue you can link to?

#27
#360

Copy link
Contributor

@nhooyr nhooyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunate it says chat instead of discord but good enough. Thank you so much <3

@NGTmeaty
Copy link
Contributor Author

NGTmeaty commented Mar 27, 2019

Would this be better @nhooyr ? We can change the label to anything we want. Could also add a discord icon to the start of it?


@grant
Copy link

grant commented Mar 27, 2019

Why don't we just keep the style? I just made this after looking at the docs.

Discord

[![Discord](https://img.shields.io/discord/463752820026376202.svg?label=&logo=discord&logoColor=ffffff&color=7389D8&labelColor=6A7EC2)](https://discord.gg/zxSwN8Z)

@coadler
Copy link
Contributor

coadler commented Mar 27, 2019

I much prefer the one @grant found :)

@kylecarbs kylecarbs merged commit 6105bba into coder:master Mar 27, 2019
@NGTmeaty NGTmeaty deleted the NGTmeaty-readme-fix branch March 27, 2019 22:05
code-asher pushed a commit that referenced this pull request Jun 19, 2019
…#364)

* Add higher quality Discord badge and add link 

to license.

* Use @grant's much better version :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants