Allow code-server to identify raspberry pi 4 (armv7l)

[janiversen]

This is a one line fix, so adding a PR seems a lot (but will do if demanded).

This fix is only interesting for developers trying to use raspberry pi 4.

With this patch yarn passes. The general plan is to work through all issues in being able to build the code on a raspberry pi 4.

Next PR will concentrate on yarn watch.

Edit:
Arch() will not either return the converted cpu type or raw “uname -m”
Fixes #3612

Checklist

• updated CHANGELOG.md

[jsjoeio]

Thanks so much for your PR @janiversen! We discussed this internally and instead we were wondering if you want to do this?

[repo-ranger]

Thanks for making your first contribution! 🙂

[codecov]

Codecov Report

Merging #3598 (012d4d6) into main (4bb7a8d) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 012d4d6 differs from pull request most recent head d282fd9. Consider uploading reports for the commit d282fd9 to get more accurate results

@@           Coverage Diff           @@
##             main    #3598   +/-   ##
=======================================
  Coverage   60.67%   60.67%           
=======================================
  Files          35       35           
  Lines        1790     1790           
  Branches      404      404           
=======================================
  Hits         1086     1086           
  Misses        562      562           
  Partials      142      142           

Impacted Files	Coverage Δ
src/node/routes/logout.ts	50.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bb7a8d...d282fd9. Read the comment docs.

[janiversen]

Changed. I am still fighting with “yarn watch” it seems to compile code-server on raspberry pi 4 is “interesting”. When I run “install.sh” it works (apart from interesting errors about the number of notify handles), so next step is to find the differences.

[jsjoeio]

I am still fighting with “yarn watch” it seems to compile code-server on raspberry pi 4 is “interesting”.

I know what you're thinking and I'm thinking it too — the yarn watch script that runs is...finicky. We're actually in the middle of migrating away from parcel which is used to bundle the browser files as part of the yarn watch process. But I would love to get this working on your environment (and all environments).

[jsjoeio]

Thanks so much for this fix! 🚀

This looks good to me. I'm going to have @oxy or @code-asher give the final approval though since they know this part of the codebase better than me.

[code-asher]

Looks good! We could use local cpu to match the general style in that file but it's not a big deal.

[janiversen]

I am not sure, what I can do about the failing CI ? (if that is a show-stopper for merging my first commit).

I know what you're thinking and I'm thinking it too — the yarn watch script that runs is...finicky. We're actually in the middle of migrating away from parcel which is used to bundle the browser files as part of the yarn watch process. But I would love to get this working on your environment (and all environments).

I just got code-server up and running on my Mac (in the background) and my iPad as front-end. I will try to build code-server on the Mac, since I can easily cross compile.

Let me know if I can help with the migration or with the 1.57 branch (the new terminal windows are going to help my daily work a lot).

[code-asher]

Failing CI is unrelated so I'll go ahead and merge this in. I think 1.57 is mostly finished but I'll leave some notes on that branch for what is left.

Thanks for the contribution!