Skip to content

chore: update node to v14 #3481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2021
Merged

chore: update node to v14 #3481

merged 1 commit into from
Jun 1, 2021

Conversation

oxy
Copy link

@oxy oxy commented May 26, 2021

Closes #3458; updates node and adds some process notes.

Checklist

  • updated CHANGELOG.md

@oxy oxy requested a review from a team as a code owner May 26, 2021 16:48
@oxy oxy force-pushed the oxy/update-node branch from 8d5b3bc to cf2e1e5 Compare May 26, 2021 17:08
@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #3481 (86d4cad) into main (c2a8634) will not change coverage.
The diff coverage is n/a.

❗ Current head 86d4cad differs from pull request most recent head 19cbddb. Consider uploading reports for the commit 19cbddb to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3481   +/-   ##
=======================================
  Coverage   59.21%   59.21%           
=======================================
  Files          35       35           
  Lines        1709     1709           
  Branches      379      379           
=======================================
  Hits         1012     1012           
  Misses        559      559           
  Partials      138      138           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2a8634...19cbddb. Read the comment docs.

Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very fast!

@oxy oxy force-pushed the oxy/update-node branch 2 times, most recently from 5587bc3 to d7ed1a8 Compare May 28, 2021 18:19
@oxy oxy requested a review from code-asher May 28, 2021 18:20
@oxy oxy force-pushed the oxy/update-node branch 4 times, most recently from f620e2b to ebab9b0 Compare May 28, 2021 18:36
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo, otherwise this looks excellent!

@oxy oxy requested a review from code-asher May 31, 2021 15:26
@oxy oxy force-pushed the oxy/update-node branch from 854652a to 19cbddb Compare June 1, 2021 15:31
@oxy oxy merged commit 58622cc into main Jun 1, 2021
@oxy oxy deleted the oxy/update-node branch June 1, 2021 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Node 14
2 participants