fix(ci): disable trivy-scan-image #3461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3461 +/- ##
=======================================
Coverage 59.21% 59.21%
=======================================
Files 35 35
Lines 1709 1709
Branches 379 379
=======================================
Hits 1012 1012
Misses 559 559
Partials 138 138 Continue to review full report at Codecov.
|
jsjoeio
changed the title
jawnsy
approved these changes
May 24, 2021
jawnsy
reviewed
May 24, 2021
| @@ -80,6 +80,7 @@ | |||
| "doctoc/**/trim": "^1.0.0", | |||
| "postcss": "^8.2.1", | |||
| "parcel-bundler/cssnano": "^5.0.2", | |||
| "browserslist": "^4.16.5", | |||
There was a problem hiding this comment.
I think it's best to keep unrelated changes in separate PRs, otherwise the commit message is misleading
There was a problem hiding this comment.
I generally agree. But CI was failing for this PR. For fixing vulnerability updates, should we merge even if CI is failing and then submit a follow-up PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR temporarily disables
trivy-scan-imagedue to an upstream issue. See: github/codeql-action#528There was a vulnerability found when CI ran. This is fixed as well:
browserslistChecklist
CHANGELOG.mdFixes #3459