Skip to content

chore: update CHANGELOG #3354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 11, 2021
Merged

chore: update CHANGELOG #3354

merged 4 commits into from
May 11, 2021

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented May 11, 2021

This PR updates the CHANGELOG.md by adding #3330

@jsjoeio jsjoeio requested a review from a team as a code owner May 11, 2021 18:32
@codecov
Copy link

codecov bot commented May 11, 2021 •
edited
Loading

Codecov Report

Merging #3354 (dc9182d) into main (74fbb42) will not change coverage.
The diff coverage is n/a.

❗ Current head dc9182d differs from pull request most recent head a7e6990. Consider uploading reports for the commit a7e6990 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3354   +/-   ##
=======================================
  Coverage   58.95%   58.95%           
=======================================
  Files          35       35           
  Lines        1703     1703           
  Branches      374      374           
=======================================
  Hits         1004     1004           
  Misses        561      561           
  Partials      138      138

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82ce9d5...a7e6990. Read the comment docs.

@jsjoeio jsjoeio self-assigned this May 11, 2021
@jsjoeio jsjoeio added the docs Documentation related label May 11, 2021
@jsjoeio jsjoeio added this to the v3.11.0 milestone May 11, 2021
oxy
oxy suggested changes May 11, 2021
View reviewed changes
Copy link

@oxy oxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can also fix the indentation here while we're at it! I can't believe I didn't catch this in review earlier >.<

@jsjoeio jsjoeio requested a review from oxy May 11, 2021 18:58
oxy
oxy suggested changes May 11, 2021
View reviewed changes
Copy link

@oxy oxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also probably change ## -> ### for 3.10.0 and for the commented-out template 😅

@jsjoeio jsjoeio requested a review from oxy May 11, 2021 19:04
oxy
oxy suggested changes May 11, 2021
View reviewed changes
oxy
oxy approved these changes May 11, 2021
View reviewed changes
Copy link

@oxy oxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good now!

@jsjoeio jsjoeio force-pushed the jsjoeio/update-changelog branch from 0947130 to a7e6990 Compare May 11, 2021 23:17
@repo-ranger repo-ranger bot merged commit c89861f into main May 11, 2021
@repo-ranger repo-ranger bot deleted the jsjoeio/update-changelog branch May 11, 2021 23:33
code-asher pushed a commit that referenced this pull request May 12, 2021
@jsjoeio @code-asher
chore: update CHANGELOG (#3354)
825a40e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxy oxy oxy approved these changes

Assignees

@jsjoeio jsjoeio

Labels
docs Documentation related
Projects
None yet
Milestone
v3.10.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jsjoeio @oxy