Skip to content

fix(build): download correct cloud-agent for arch #3331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2021
Merged

Conversation

oxy
Copy link

@oxy oxy commented May 10, 2021

Fixes the npm postinstall script, which is also used to download cloud-agent, to download based on the system architecture.

@oxy oxy requested a review from a team as a code owner May 10, 2021 07:21
@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #3331 (6ffe388) into main (02a0e05) will not change coverage.
The diff coverage is n/a.

❗ Current head 6ffe388 differs from pull request most recent head d54da76. Consider uploading reports for the commit d54da76 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3331   +/-   ##
=======================================
  Coverage   58.95%   58.95%           
=======================================
  Files          35       35           
  Lines        1703     1703           
  Branches      374      374           
=======================================
  Hits         1004     1004           
  Misses        561      561           
  Partials      138      138           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02a0e05...d54da76. Read the comment docs.

@oxy oxy self-assigned this May 10, 2021
@oxy oxy added this to the v3.10.0 milestone May 10, 2021
esac
}

ARCH="${NPM_CONFIG_ARCH:-$(detect_arch)}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big ol' nit but I'm thinking we should move this inside main to match OS.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will look at it for 3.11/3.10.1 - tested this locally for both amd64/arm64, and don't want to shake things up with changes on release day

@oxy oxy merged commit 930b046 into main May 10, 2021
@oxy oxy deleted the oxy/cloud-agent-arm64 branch May 10, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants