Skip to content

chore(lib/vscode): remove gulp-azure-storage from deps #3310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2021

Conversation

oxy
Copy link

@oxy oxy commented May 7, 2021

azure-storage is deprecated, pulls in a vulnerable version of a dependency, and we don't use the build steps from VSCode that depend on it anyway.

@oxy oxy requested a review from a team as a code owner May 7, 2021 17:16
@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #3310 (bc400bb) into main (4f320ad) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3310   +/-   ##
=======================================
  Coverage   58.95%   58.95%           
=======================================
  Files          35       35           
  Lines        1703     1703           
  Branches      374      374           
=======================================
  Hits         1004     1004           
  Misses        561      561           
  Partials      138      138           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dcf098...bc400bb. Read the comment docs.

@oxy oxy merged commit b21a9af into main May 7, 2021
@oxy oxy deleted the oxy/remove-azure-storage branch May 7, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants