Skip to content

chore(deps): bump lodash from 4.17.20 to 4.17.21 in /lib/vscode/build #3301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 6, 2021

Bumps lodash from 4.17.20 to 4.17.21.

Commits
  • f299b52 Bump to v4.17.21
  • c4847eb Improve performance of toNumber, trim and trimEnd on large input strings
  • 3469357 Prevent command injection through _.template's variable option
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot requested a review from a team as a code owner May 6, 2021 19:26
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript labels May 6, 2021
@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #3301 (f97f853) into main (b21a9af) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3301   +/-   ##
=======================================
  Coverage   58.95%   58.95%           
=======================================
  Files          35       35           
  Lines        1703     1703           
  Branches      374      374           
=======================================
  Hits         1004     1004           
  Misses        561      561           
  Partials      138      138           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b21a9af...f97f853. Read the comment docs.

Copy link

@oxy oxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@oxy oxy self-requested a review May 6, 2021 19:35
Copy link

@oxy oxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need another look to see if 1.56 still needs the fix.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/lib/vscode/build/lodash-4.17.21 branch 2 times, most recently from fa895f0 to 470e324 Compare May 6, 2021 22:12
@oxy
Copy link

oxy commented May 7, 2021

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/lib/vscode/build/lodash-4.17.21 branch from 470e324 to 1b70ae9 Compare May 7, 2021 01:52
Copy link

@oxy oxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jsjoeio
Copy link
Contributor

jsjoeio commented May 7, 2021

error Your lockfile needs to be updated, but yarn was run with --frozen-lockfile.

Lockfile needs to be updated

@oxy
Copy link

oxy commented May 7, 2021

@dependabot rebase
Yep, was addressed in the PR I just merged!

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/lib/vscode/build/lodash-4.17.21 branch from 1b70ae9 to f97f853 Compare May 7, 2021 17:28
@jsjoeio jsjoeio merged commit e7ce4f8 into main May 7, 2021
@jsjoeio jsjoeio deleted the dependabot/npm_and_yarn/lib/vscode/build/lodash-4.17.21 branch May 7, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants