Test static route #3297
Merged
Test static route #3297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3297 +/- ##
==========================================
+ Coverage 56.95% 58.95% +1.99%
==========================================
Files 35 35
Lines 1703 1703
Branches 374 374
==========================================
+ Hits 970 1004 +34
+ Misses 583 561 -22
+ Partials 150 138 -12
Continue to review full report at Codecov.
|
jsjoeio
suggested changes
May 5, 2021
code-asher
force-pushed
the
test-static
branch
6 times, most recently
from
b44ba1e to
e382328
Compare
|
I need to refactor the logger module mock because it causes errors in the e2e tests (now that the terminal test imports the helper file) but that conflicts with some constant test changes you're making so I'm going to wait for that to get merged then rebase. |
|
This is to match the other tests that create temp directories. It also lets you clean up test temp directories all at once separately from other non-test temporary directories.
Just to limit all the noise from code-server's startup output.
code-asher
force-pushed
the
test-static
branch
2 times, most recently
from
01f695f to
eb34f4b
Compare
It errors that jest is not defined so put it behind a function instead of immediately creating the mock (this is probably a better pattern anyway). The constant tests had to be reworked a little. Since the logger mock is hoisted it runs before createLoggerMock is imported. I moved it into a beforeAll which means the require call also needed to be moved there (since we need to mock the logger before requiring the constants or it'll pull the non-mocked logger). This means getPackageJson needs to be a let and assigned afterward. To avoid having to define a type for getPackageJson I just added a let var set to the type of the imported constants file and modified the other areas to use the same paradigm. I also replaced some hardcoded strings with the mocked package.json object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly just wanted to add a test for static auth.