Skip to content

feat(ci/build): support arm64 for cloud-agent #3294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2021
Merged

Conversation

oxy
Copy link

@oxy oxy commented May 5, 2021

Move to downloading from GitHub releases. 🎉

@oxy oxy requested a review from a team as a code owner May 5, 2021 12:45
@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #3294 (e5ee026) into main (0d9fe6f) will increase coverage by 7.87%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3294      +/-   ##
==========================================
+ Coverage   46.90%   54.78%   +7.87%     
==========================================
  Files          23       23              
  Lines        1196     1265      +69     
  Branches      237      286      +49     
==========================================
+ Hits          561      693     +132     
- Misses        451      460       +9     
+ Partials      184      112      -72     
Impacted Files Coverage Δ
src/node/http.ts 27.86% <0.00%> (-6.18%) ⬇️
src/node/vscode.ts 27.50% <0.00%> (-2.64%) ⬇️
src/node/wrapper.ts 33.12% <0.00%> (-0.43%) ⬇️
src/node/entry.ts 0.00% <0.00%> (ø)
src/common/emitter.ts 100.00% <0.00%> (ø)
src/node/proxy_agent.ts 0.00% <0.00%> (ø)
src/browser/pages/vscode.ts 0.00% <0.00%> (ø)
src/node/socket.ts 90.00% <0.00%> (+0.34%) ⬆️
src/node/plugin.ts 68.18% <0.00%> (+0.58%) ⬆️
src/node/heart.ts 72.41% <0.00%> (+2.04%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d9fe6f...e5ee026. Read the comment docs.

Copy link
Contributor

@jawnsy jawnsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@oxy oxy merged commit fa461ff into main May 5, 2021
@oxy oxy deleted the oxy/cloud-agent-arch branch May 5, 2021 16:23
@jsjoeio jsjoeio linked an issue May 7, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No arm64 binary for Cloud Agent
2 participants