Skip to content

Update Dockerfile #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Update Dockerfile #327

merged 1 commit into from
Mar 27, 2019

Conversation

JimiPedros
Copy link
Contributor

Describe in detail the problem you had and how this PR fixes it

The issue I faced was installing packages using Pip.
I fixed this with the command export LC_ALL=C.
This could be added to the docker to save other people from experiencing the same issue.

Is there an open issue you can link to?

Issue #326

@JimiPedros JimiPedros requested a review from nhooyr as a code owner March 24, 2019 07:50
Copy link
Contributor

@NGTmeaty NGTmeaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nhooyr

@kylecarbs kylecarbs merged commit 3331f9b into coder:master Mar 27, 2019
code-asher pushed a commit that referenced this pull request Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants