Skip to content

docs(faq): add entry for accessing OSX folders #3247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented Apr 28, 2021

the real credit goes to @noahsbwilliams for discovering and sharing this in #2794. I figured it should mandate a FAQ entry since it is a known issue

@bpmct bpmct requested a review from a team as a code owner April 28, 2021 00:41
@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #3247 (5c59c79) into main (9f7ceef) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3247   +/-   ##
=======================================
  Coverage   46.90%   46.90%           
=======================================
  Files          23       23           
  Lines        1196     1196           
  Branches      237      237           
=======================================
  Hits          561      561           
  Misses        451      451           
  Partials      184      184           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f7ceef...5c59c79. Read the comment docs.

Copy link
Contributor

@jawnsy jawnsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! It seems good to me, but I'm not a Mac person so please wait for @jsjoeio to take a look 😄

@jawnsy jawnsy requested a review from jsjoeio April 28, 2021 01:14
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding this @bpmct 🙌

Feel free to merge!

@jsjoeio jsjoeio changed the title add FAQ entry for accessing OSX folders docs(faq): add entry for accessing OSX folders Apr 28, 2021
@jsjoeio jsjoeio added the docs Documentation related label Apr 28, 2021
@jsjoeio jsjoeio added this to the v3.9.4 milestone Apr 28, 2021
@noahsbwilliams
Copy link

Glad I could help! This permissions scheme sure doesn't make it easy...

@bpmct bpmct merged commit 6dace0f into coder:main Apr 29, 2021
@bpmct bpmct deleted the osx-folders branch April 29, 2021 17:29
@jsjoeio jsjoeio added the chore Related to maintenance or clean up label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants