Feature/relative url #307
Merged
Feature/relative url #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Problems still exist while using relative url ("resource"). |
|
@kylecarbs - I know this is only a week old, but do you have an estimate for when you'll be able to review this PR? Thanks! |
|
polite ping |
kylecarbs
requested changes
Apr 4, 2019
| @@ -47,7 +47,8 @@ const newCreateElement = <K extends keyof HTMLElementTagNameMap>(tagName: K): HT | |||
| }, | |||
| set: (value: string): void => { | |||
| if (value) { | |||
| value = value.replace(/file:\/\//g, "/resource"); | |||
| const resourceBaseUrl = location.pathname.replace(/\/$/, "") + "/resource"; | |||
There was a problem hiding this comment.
Wouldn't this only catch URLs that end with /?
Something like https://ide.kwc.io/banana wouldn't be caught with this.
There was a problem hiding this comment.
This makes sure the url is correct.
Both
https://ide.kwc.io/banana
https://ide.kwc.io/banana/
use
https://ide.kwc.io/banana/resource
to request the resources
|
any chance of getting this merged in for the next release? this is a pretty big issue for how my environment is atm (of which I have limited control) |
code-asher
approved these changes
Apr 11, 2019
Closed
code-asher
pushed a commit
that referenced
this pull request
Jun 19, 2019
* resrouce relative url * add url pathname for require.toUrl (fix webview url) * rest resrouce relative url * fix resource url * ignore .vscode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #241
Describe in detail the problem you had and how this PR fixes it
Is there an open issue you can link to?