Skip to content

fix: update ranger file #3065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2021
Merged

fix: update ranger file #3065

merged 1 commit into from
Apr 7, 2021

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Apr 7, 2021

This PR fixes a couple syntax issues in the ranger.yml configuration and adjusts the close time to 2 days instead of 3.

I thought we could define our own custom actions but I don't think that's the case after re-reading the docs and asking the maintainer why it wasn't working 😂.

@jsjoeio jsjoeio added this to the v3.9.3 milestone Apr 7, 2021
@jsjoeio jsjoeio self-assigned this Apr 7, 2021
@jsjoeio jsjoeio requested a review from a team as a code owner April 7, 2021 16:57
@@ -26,7 +24,7 @@ labels:
delay: 5s
message: "Thanks for making your first contribution! :slightly_smiling_face:"
extension-request:
action: close-faster
action: close
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsjoeio Ah that's too bad that there's no schema validator for these, I would expect some sort of warning if fields are unknown

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right? Well based on what I read and saw in the config, I just assumed I could create my own custom actions like this: https://github.com/cdr/code-server/pull/3065/files#diff-15592ca299f8c76c553cc34e528b303896afa722a32d8f983cdcf67dfa7b38f1L11-L12

But turns out that is not the case 😂

@jsjoeio jsjoeio enabled auto-merge April 7, 2021 17:00
Copy link

@oxy oxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jsjoeio jsjoeio force-pushed the jsjoeio/fix-ranger-syntax branch from b978505 to f09a081 Compare April 7, 2021 17:46
@jsjoeio jsjoeio merged commit c8b77a2 into main Apr 7, 2021
@jsjoeio jsjoeio deleted the jsjoeio/fix-ranger-syntax branch April 7, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants