feat(ci): add audit job for security #3042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jawnsy
approved these changes
Apr 5, 2021
There was a problem hiding this comment.
LGTM! 👍
I'm curious generally where this tool gets its data from, and why Dependabot seems to have missed some of the flagged issues?
I think we'll need several of these tools because they scan different things and in different ways (this covers us for vulns in code-server itself, but not for other stuff that we include in our code-server docker images, for example)
jsjoeio
force-pushed
the
jsjoeio/audit-ci
branch
from
54ca2af to
1dd3b42
Compare
jsjoeio
force-pushed
the
jsjoeio/audit-ci
branch
from
1dd3b42 to
6f98e08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new CI job using
audit-cito check for vulnerabilities usingyarn audit.Inspired by @PatrickDerichs and #2964
NOTE: I don't think
auditwill pass until #3041 is merged and I rebase.TODOS
package.json, add asdevDependencyand add script to run in CI)