Skip to content

chore(deps): bump xdg-basedir from 4.0.0 to 5.0.1 #3034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 5, 2021

Bumps xdg-basedir from 4.0.0 to 5.0.1.

Release notes

Sourced from xdg-basedir's releases.

v5.0.1

  • Fix some mistakes in v5 1c00d3b

sindresorhus/xdg-basedir@v5.0.0...v5.0.1

v5.0.0

Breaking

  • Require Node.js 12 e1b957d
  • Changed from default export to named exports. See this diff for how to migrate.
  • This package is now pure ESM. Please read this.

sindresorhus/xdg-basedir@v4.0.0...v5.0.0

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually

@dependabot dependabot bot requested a review from a team as a code owner April 5, 2021 11:02
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript labels Apr 5, 2021
@jawnsy
Copy link
Contributor

jawnsy commented Apr 5, 2021

Looks like this one will need some manual work due to breaking changes. Awesome that our test coverage caught this 👍

$ tsc
FAIL test/unit/cli.test.ts
  ● Test suite failed to run

    src/node/util.ts:32:20 - error TS2339: Property 'data' does not exist on type 'typeof import("/github/workspace/node_modules/xdg-basedir/index")'.

    32     if (xdgBasedir.data === undefined || xdgBasedir.config === undefined) {
                          ~~~~
    src/node/util.ts:32:53 - error TS2339: Property 'config' does not exist on type 'typeof import("/github/workspace/node_modules/xdg-basedir/index")'.

    32     if (xdgBasedir.data === undefined || xdgBasedir.config === undefined) {
                                                           ~~~~~~
    src/node/util.ts:36:34 - error TS2339: Property 'data' does not exist on type 'typeof import("/github/workspace/node_modules/xdg-basedir/index")'.

    36       data: path.join(xdgBasedir.data, "code-server"),
                                        ~~~~
    src/node/util.ts:37:36 - error TS2339: Property 'config' does not exist on type 'typeof import("/github/workspace/node_modules/xdg-basedir/index")'.

    37       config: path.join(xdgBasedir.config, "code-server"),
        

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/xdg-basedir-5.0.1 branch from 66c81fc to cbdbcd7 Compare April 5, 2021 23:44
@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 5, 2021

Right?! Yay tests!

So I pulled down locally and refactored the default export to use the new named exports, but then I realized this is going to require more work. The new version of this package is pure ESM.

In order to use ESM with jest, ts-jest and the rest of the project, it will require a lot of changes. I don't think we're ready to make that transition yet so I'm going to close this. I'll open a separate PR to limit version updates for this package.

@jsjoeio jsjoeio closed this Apr 5, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 5, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/xdg-basedir-5.0.1 branch April 5, 2021 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants