chore(dev-deps): bump @types/node to 12.20.7 #3012
Conversation
jsjoeio
changed the title
jsjoeio
force-pushed
the
jsjoeio/bump-types-node
branch
from
9f30ae5 to
c7d7041
Compare
| @@ -41,7 +41,7 @@ | |||
| "@types/express": "^4.17.8", | |||
| "@types/http-proxy": "^1.17.4", | |||
| "@types/js-yaml": "^4.0.0", | |||
| "@types/node": "^12.12.7", | |||
| "@types/node": "~12.20.7", | |||
There was a problem hiding this comment.
Not sure if ~ is intentional here to keep us on the 12.20.x series instead of the 12.x series (which would be behavior for ^) - @jsjoeio
There was a problem hiding this comment.
It was made intentionally! I was thinking we should stay on 12.20.x series but open to changing it if you think that's the wrong move!
There was a problem hiding this comment.
I don't know enough about @types/node to know for sure, I think I'd defer to your judgements, though feel free to pull in asher for another opinion!
There was a problem hiding this comment.
I think it's okay then. I think we make it strict like this with ~ and if that's the wrong move, then we reverse it. Easily reversible!
There was a problem hiding this comment.
Since we support a range of Node versions I'm not really sure what versions of the types we should use.
I suppose we should keep it in sync with whatever we use to build in CI? So if we use Node 12.20.x then we use 12.20.x types, etc.
There was a problem hiding this comment.
I'm in agreement! Sounds good to me!
jsjoeio
force-pushed
the
jsjoeio/bump-types-node
branch
from
c7d7041 to
c415fd2
Compare
This PR bumps
@types/nodeto12.20.7Tested locally using
node 12.20.2and everything works as expected.Related: