Skip to content

chore(deps-dev): bump @types/ws from 7.2.7 to 7.4.0 #2871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 12, 2021

Bumps @types/ws from 7.2.7 to 7.4.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner March 12, 2021 19:50
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript labels Mar 12, 2021
@dependabot dependabot bot requested a review from jawnsy March 12, 2021 19:50
@jawnsy
Copy link
Contributor

jawnsy commented Mar 12, 2021

Strangely, the versions mentioned here don't seem to match the tagged versions in websockets/ws, which these should be types for? 🤔

image

@code-asher
Copy link
Member

Huh yeah looks like they only match up to the minor version:

https://github.com/DefinitelyTyped/DefinitelyTyped#how-do-definitely-typed-package-versions-relate-to-versions-of-the-corresponding-library

@code-asher
Copy link
Member

code-asher commented Mar 12, 2021

So I suppose that means if we update the types to 7.4.x we should also make sure ws is updated to 7.4.y.

Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yolo merge 👀

@code-asher code-asher merged commit 3f3a619 into main Mar 15, 2021
@code-asher code-asher deleted the dependabot/npm_and_yarn/types/ws-7.4.0 branch March 15, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants