Skip to content

dev(update-vscode.sh): get latest vscode version and force commit files #2859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 11, 2021
Merged

dev(update-vscode.sh): get latest vscode version and force commit files #2859

merged 6 commits into from
Mar 11, 2021

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Mar 10, 2021 •
edited
Loading

This PR modifies the update-vscode.sh script and greatly improves it:

  • add more comments
  • get latest version of vscode from package.json
  • force commit conflicted files
  • add more detailed PR message in draft PR

Fixes #2787

@jsjoeio jsjoeio requested a review from a team as a code owner March 10, 2021 22:10
@jsjoeio jsjoeio changed the title feat(update-vscode): grab latest vscode version dev(update-vscode.sh): grab latest vscode version Mar 10, 2021
@jsjoeio jsjoeio mentioned this pull request Mar 10, 2021
Closed
2 tasks
@jsjoeio jsjoeio self-assigned this Mar 10, 2021
@jsjoeio jsjoeio added this to the v3.9.2 milestone Mar 10, 2021
@jsjoeio jsjoeio marked this pull request as draft March 10, 2021 22:21
@jsjoeio jsjoeio force-pushed the jsjoeio/update-upgrade-vscode-script branch 3 times, most recently from ae457e7 to 651dc38 Compare March 11, 2021 00:09
@jsjoeio jsjoeio force-pushed the jsjoeio/update-upgrade-vscode-script branch from 651dc38 to a4d8415 Compare March 11, 2021 00:14
@jsjoeio jsjoeio marked this pull request as ready for review March 11, 2021 00:14
@jsjoeio jsjoeio changed the title dev(update-vscode.sh): grab latest vscode version dev(update-vscode.sh): get latest vscode version and force commit files Mar 11, 2021
@jsjoeio jsjoeio force-pushed the jsjoeio/update-upgrade-vscode-script branch from a4d8415 to 3e79a84 Compare March 11, 2021 16:48
oxy
oxy approved these changes Mar 11, 2021
View reviewed changes
Copy link

@oxy oxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsjoeio jsjoeio merged commit fa71191 into main Mar 11, 2021
@jsjoeio jsjoeio deleted the jsjoeio/update-upgrade-vscode-script branch March 11, 2021 20:15
@jsjoeio jsjoeio added the chore Related to maintenance or clean up label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxy oxy oxy approved these changes

Assignees

@jsjoeio jsjoeio

Labels
chore Related to maintenance or clean up
Projects
None yet
Milestone
v3.9.2
Development

Successfully merging this pull request may close these issues.

[dev]: improve update-vscode.sh script
2 participants
@jsjoeio @oxy