Skip to content

Implement missing terminal method #2857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Implement missing terminal method #2857

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/vscode/src/vs/server/node/channel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,6 +606,10 @@ class Terminal {
return this.process.input(data);
}

public acknowledgeDataEvent(charCount: number): void {
return this.process.acknowledgeDataEvent(charCount);
}

public resize(cols: number, rows: number): void {
this.cols = cols;
this.rows = rows;
Expand Down Expand Up @@ -658,6 +662,7 @@ export class TerminalProviderChannel implements IServerChannel<RemoteAgentConnec
case '$createTerminalProcess': return this.createTerminalProcess(context.remoteAuthority, args);
case '$startTerminalProcess': return this.startTerminalProcess(args);
case '$sendInputToTerminalProcess': return this.sendInputToTerminalProcess(args);
case '$sendCharCountToTerminalProcess': return this.sendCharCountToTerminalProcess(args);
case '$shutdownTerminalProcess': return this.shutdownTerminalProcess(args);
case '$resizeTerminalProcess': return this.resizeTerminalProcess(args);
case '$getTerminalInitialCwd': return this.getTerminalInitialCwd(args);
Expand Down Expand Up @@ -827,6 +832,10 @@ export class TerminalProviderChannel implements IServerChannel<RemoteAgentConnec
return this.getTerminal(args.id).input(args.data);
}

private async sendCharCountToTerminalProcess(args: terminal.ISendCharCountToTerminalProcessArguments): Promise<void> {
return this.getTerminal(args.id).acknowledgeDataEvent(args.charCount);
}

private async shutdownTerminalProcess(args: terminal.IShutdownTerminalProcessArguments): Promise<void> {
return this.getTerminal(args.id).shutdown(args.immediate);
}
Expand Down