Skip to content

docs(npm): update node requirements #2850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2021
Merged

docs(npm): update node requirements #2850

merged 2 commits into from
Mar 10, 2021

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Mar 9, 2021

This PR fixes #2745 by adding extra information regarding Node.js requirements.

TODOS

  • open separate issue for pre-install script that checks node version [dev]: pre-install script that checks dependencies #2807
  • verify that v10 node works with code-server Couldn't get v10 Node to play nicely with code-server.
  • verify that v14 node works with code-server
  • issues with v15 as well
  • update docs

How I tested versions of node:

  1. nvm install 14
  2. rm -rf node_modules
  3. yarn
  4. cd lib/vscode && npm rebuild
  5. yarn watch
  6. Navigate to localhost:8080 and see if code-server works

@jsjoeio jsjoeio added this to the v3.9.2 milestone Mar 9, 2021
@jsjoeio jsjoeio requested a review from a team as a code owner March 9, 2021 18:21
@jsjoeio jsjoeio self-assigned this Mar 9, 2021
@code-asher
Copy link
Member

Thoughts on whether we should have a pre-install script that forces the correct version of Node?

Also I'm not sure v10 or v14 works so we should definitely test them. If not then we'll want to restrict to v12 only.

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Mar 9, 2021

Thoughts on whether we should have a pre-install script that forces the correct version of Node?

Great idea! I think that could come in a separate PR. I'll open an issue for it. There's one open here: #2807

Also I'm not sure v10 or v14 works so we should definitely test them. If not then we'll want to restrict to v12 only.

Good call. Let me move to draft and test.

@jsjoeio jsjoeio marked this pull request as draft March 9, 2021 18:53
@jsjoeio jsjoeio force-pushed the jsjoeio-docs-2745 branch from c10582b to 6f9372d Compare March 9, 2021 21:48
@jsjoeio jsjoeio marked this pull request as ready for review March 9, 2021 21:48
@jsjoeio jsjoeio requested a review from code-asher March 9, 2021 21:48
@jsjoeio jsjoeio force-pushed the jsjoeio-docs-2745 branch from 6f9372d to 0cb5c2e Compare March 10, 2021 17:47
@jsjoeio jsjoeio merged commit c801a98 into main Mar 10, 2021
@jsjoeio jsjoeio deleted the jsjoeio-docs-2745 branch March 10, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update npm installation docs with node requirements
2 participants