Skip to content

Support permessage-deflate web socket extension #2846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2021
Merged

Support permessage-deflate web socket extension #2846

merged 1 commit into from
Mar 10, 2021

Conversation

code-asher
Copy link
Member

No description provided.

@code-asher code-asher requested a review from a team as a code owner March 8, 2021 23:06
jsjoeio
jsjoeio approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

non-blocking: might help me (future us) if you add a bit more to the description:

  • what this adds
  • why we're adding it

@code-asher
Copy link
Member Author

code-asher commented Mar 9, 2021 •
edited
Loading

Ah yup sure thing:

  1. This enables using permessage-deflate which is a web socket extension that enables compression. https://tools.ietf.org/html/rfc7692
  2. Support for it was added by the 1.53 update but I didn't actually enable it until now.

@jsjoeio
Copy link
Contributor

jsjoeio commented Mar 9, 2021

Sweet! Thanks man. Ship it!

@jsjoeio jsjoeio added this to the v3.9.2 milestone Mar 9, 2021
@code-asher code-asher merged commit 5a1f62a into main Mar 10, 2021
@code-asher code-asher deleted the permessage-deflate branch March 10, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsjoeio jsjoeio jsjoeio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.9.2
Development

Successfully merging this pull request may close these issues.
2 participants
@code-asher @jsjoeio