Skip to content

docs(README): add release shield #2813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2021
Merged

docs(README): add release shield #2813

merged 1 commit into from
Mar 2, 2021

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Mar 2, 2021

This PR adds a release shield to the README

Screenshot

image

@jsjoeio jsjoeio added this to the v3.9.1 milestone Mar 2, 2021
@jsjoeio jsjoeio requested review from greyscaled and a team March 2, 2021 22:03
@jsjoeio jsjoeio self-assigned this Mar 2, 2021
Copy link
Contributor

@greyscaled greyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! One potential issue I could see is if a patch to prior release is newer by date than the latest release. We could get around that through using GitHub release (latest SemVer) from https://shields.io/category/version, but I don't suspect we'll face this problem atm.

Thanks for adding this! 🎉

@jsjoeio jsjoeio force-pushed the add-version-shield branch from 063c67d to 16747f1 Compare March 2, 2021 22:14
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Mar 2, 2021

Good call! I didn't think of that. I switched it to use the GitHub release (latest SemVer) as you suggested! 🙌

@jsjoeio jsjoeio removed the request for review from a team March 2, 2021 22:20
@jsjoeio jsjoeio merged commit 3ab0ff3 into master Mar 2, 2021
@jsjoeio jsjoeio deleted the add-version-shield branch March 2, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants