Skip to content

Open localhost URL with --open #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2019
Merged

Open localhost URL with --open #28

merged 2 commits into from
Mar 7, 2019

Conversation

fand
Copy link
Contributor

@fand fand commented Mar 6, 2019

CLI option --open is not working now.

I implemented --open with this npm package:
https://github.com/sindresorhus/opn

@fand fand closed this Mar 6, 2019
@fand fand reopened this Mar 6, 2019
@fand
Copy link
Contributor Author

fand commented Mar 7, 2019

seems tests are failing beacuse of API rate limit on cloning vscode-ripgrep.
I'll close/reopen PR just to trigger rebuild.

@fand fand closed this Mar 7, 2019
@fand fand reopened this Mar 7, 2019
@sr229
Copy link
Contributor

sr229 commented Mar 7, 2019

@frand It's a Travis-side issue. NPMJS seems to ratelimit the CI fsr, recommend you wait it out for 3 hours

@fand fand closed this Mar 7, 2019
@fand fand reopened this Mar 7, 2019
@kylecarbs
Copy link
Member

We'll be fixing the CI for PRs soon.

@kylecarbs kylecarbs merged commit 87d2e22 into coder:master Mar 7, 2019
code-asher pushed a commit that referenced this pull request Jun 19, 2019
* Open localhost URL with --open

* Catch errors on opn

Co-Authored-By: fand <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants