Skip to content

Allow plugins to register at the root #2722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 12, 2021
Merged

Allow plugins to register at the root #2722

merged 3 commits into from
Feb 12, 2021

Conversation

code-asher
Copy link
Member

No description provided.

@code-asher
Allow plugins to register at the root
0abbc97 
Unfortunately we have existing plugins with routes there which we cannot
move.
@code-asher code-asher requested a review from jsjoeio February 12, 2021 21:44
@code-asher code-asher changed the base branch from v3.8.1 to master February 12, 2021 21:45
@code-asher code-asher changed the title Root plugin Allow plugins to register at the root Feb 12, 2021
jsjoeio
jsjoeio approved these changes Feb 12, 2021
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@code-asher code-asher merged commit c2450d6 into master Feb 12, 2021
@code-asher code-asher deleted the root-plugin branch February 12, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsjoeio jsjoeio jsjoeio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@code-asher @jsjoeio