Add .node-version file #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do lots of people want this addition? It's very small, but I could see this getting out of hand with version files. |
|
Maybe yes. Some contributors or developers who try to build code-server locally fail to build code-server due to Node.js version does not match its version requiring to build code-server. Because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe in detail the problem you had and how this PR fixes it
Many developers are using **env tools such as nodenv to treat various version environments in each project.
nodenv is specifying node version for projects using by .node-version file.
So, this PR adds
.node-versionfile for using nodenv and sets node version v8.15.0 according to Dockerfile.Is there an open issue you can link to?
None.