-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Replace gallery with Open-VSX #2659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
One thing I haven't gotten around to testing yet is if the vscodevim extension from openvsx works with 1.52.1 and the web extension changes that were made there. |
@oxy anything else you need from us to help move this forward? |
Not really! I'm working on a second pass on the docs (should be done in the hour) and then we should be ready to merge! |
Since this is still in progress and I don't want us to accidentally merge, going to move to draft |
I did actually finish the docs and merge them into this PR - just forgot to merge this one >~< |
Moving back to draft - we need to test this with Vim |
Just tested the latest version from OpenVSX, seems to work fine: Vim-OpenVSX.mp4 |
Ah yup if you install it manually it should work but installing from the UI seems to break because it attempts to load it as a web extension which OpenVSX doesn't seem to support yet. |
Regardless, thanks for testing it out and posting a video @pojntfx 🎉 Hopefully we can get this sorted soon! |
Closing for now because we need a few things in place before we can fully implement and merge this PR |
After discussing internally, we've decided to just switch our default extension gallery to Open-VSX, and then document how to switch back to our old gallery. This PR just changes the default, and documentation changes are still required before we can make a release!
The hack I attempted previously broke pagination, and there is no obvious, non-invasive fix in sight due to how VSCode was designed.
Note that switching back should essentially be setting
GALLERY_URL="https://extensions.coder.com/api" ITEM_URL=
(intentionally blank).Closes #1473.
TODOS