Send 'loaded' event to all parent origins #2641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-asher
approved these changes
Jan 26, 2021
deansheather
force-pushed
the
send-ready-to-all-origins
branch
from
24ce7f3 to
42dcfc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This event isn't sensitive, so it should be sent to all parent origins. Some situations may require running an iframe to code-server on a separate domain to the code-server instance, and they might want to listen to this event.
window.location.originlimited this event to only the same domain.This does not change the iframe behavior in any other way. Iframes are still allowed by default unless explicitly blocked via response headers or another mechanism.