Skip to content

vscode.ts: Fix close current folder #2596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 20, 2021
Merged

vscode.ts: Fix close current folder #2596

merged 2 commits into from
Jan 20, 2021

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Jan 18, 2021

Fixes VscodeProvider to correctly obey the ew parameter.

Based on changes by @rdbeach. See the previous commit.

rdbeach and others added 2 commits January 18, 2021 11:28
When you choose to close the current folder, it doesn't close properly
because the lastVisiited setting is still use. This fixes that.
Fixes VscodeProvider to correctly obey the ew parameter.

Based on changes by @rdbeach. See the previous commit.
@nhooyr nhooyr requested a review from code-asher January 18, 2021 16:30
@nhooyr
Copy link
Contributor Author

nhooyr commented Jan 18, 2021

Tested and this works great!

Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@nhooyr nhooyr merged commit c17f3ff into master Jan 20, 2021
@nhooyr nhooyr deleted the rdbeach branch January 20, 2021 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants