Skip to content

Update FAQ for proper hashed-password generation #2503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update FAQ for proper hashed-password generation #2503

wants to merge 1 commit into from

Conversation

confusedguy9
Copy link

Get rid of the automatically inserted trailing newline.

@confusedguy9
Update FAQ for proper hashed-password generation
6015a75 
Get rid of the automatically inserted trailing newline.
@jsjoeio
Copy link
Contributor

jsjoeio commented Dec 22, 2020

Thanks for the doc fix @confusedguy9! Do you mind changing your base branch to master? Then I can approve and merge this. Thank you!

@jsjoeio jsjoeio self-requested a review December 22, 2020 23:15
@confusedguy9 confusedguy9 changed the base branch from v3.8.0 to master December 25, 2020 16:35
@confusedguy9
Copy link
Author

I've changed the base branch as requested.

@SPGoding SPGoding mentioned this pull request Dec 30, 2020
Merged
@nhooyr
Copy link
Contributor

nhooyr commented Jan 6, 2021

Let's use printf here instead of echo! That way the same example should work correctly across all unix based OSes like the BSDs as well.

@code-asher code-asher mentioned this pull request Jan 14, 2021
Closed
@code-asher
Copy link
Member

Thanks again for the PR! I went ahead and merged #2533 which has the printf fix.

@code-asher code-asher closed this Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsjoeio jsjoeio Awaiting requested review from jsjoeio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@confusedguy9 @jsjoeio @nhooyr @code-asher