Skip to content

refactor (vscode): migrate from submodule to subtree #2476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Dec 17, 2020
Merged

refactor (vscode): migrate from submodule to subtree #2476

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
6c5c22e
chore: remove submodule
jsjoeio Dec 15, 2020
be3e823
Squashed 'lib/vscode/' content from commit e5a624b788
jsjoeio Dec 15, 2020
41bee49
Merge commit 'be3e8236086165e5e45a5a10783823874b3f3ebd' as 'lib/vscode'
jsjoeio Dec 15, 2020
51a2a2a
feat: apply patch after setting up subtree
jsjoeio Dec 15, 2020
25e6f84
feat: remove vscode scripts used with submodule
jsjoeio Dec 15, 2020
fcc16e5
refactor: move vscode.sh to postinstall
jsjoeio Dec 16, 2020
5830532
refactor: remove submodule code from steps scripts
jsjoeio Dec 16, 2020
e391f68
docs: update workflow and remove yarn vscode
jsjoeio Dec 16, 2020
b176e3e
refactor: update workflow in codetour
jsjoeio Dec 16, 2020
5b4fb69
docs: fix codetour and docs
jsjoeio Dec 16, 2020
65ff47b
docs: update based on feedback
jsjoeio Dec 16, 2020
be97f80
fix: add grep -v lib/vscode to git ls-files
jsjoeio Dec 16, 2020
fdde5a8
chore: format lint file
jsjoeio Dec 17, 2020
74d6d5e
fix: remove unnecessary grep line in fmt script
jsjoeio Dec 17, 2020
9a16e4e
docs: add section for updating vs code
jsjoeio Dec 17, 2020
98338e9
chore: fix linting error
jsjoeio Dec 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ci/dev/fmt.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -euo pipefail
main() {
cd "$(dirname "$0")/../.."

shfmt -i 2 -w -sr $(git ls-files "*.sh")
shfmt -i 2 -w -sr $(git ls-files "*.sh" | grep -v "lib/vscode")

local prettierExts
prettierExts=(
Expand All @@ -20,7 +20,7 @@ main() {
"*.yml"
)
prettier --write --loglevel=warn $(
git ls-files "${prettierExts[@]}" | grep -v 'helm-chart'
git ls-files "${prettierExts[@]}" | grep -v "lib/vscode" | grep -v 'helm-chart'
)

doctoc --title '# FAQ' doc/FAQ.md > /dev/null
Expand All @@ -30,7 +30,7 @@ main() {
doctoc --title '# Contributing' doc/CONTRIBUTING.md > /dev/null
doctoc --title '# iPad' doc/ipad.md > /dev/null

if [[ ${CI-} && $(git ls-files --other --modified --exclude-standard) ]]; then
if [[ ${CI-} && $(git ls-files --other --modified --exclude-standard | grep -v "lib/vscode") ]]; then
echo "Files need generation or are formatted incorrectly:"
git -c color.ui=always status | grep --color=no '\[31m'
echo "Please run the following locally:"
Expand Down
6 changes: 3 additions & 3 deletions ci/dev/lint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ set -euo pipefail
main() {
cd "$(dirname "$0")/../.."

eslint --max-warnings=0 --fix $(git ls-files "*.ts" "*.tsx" "*.js")
stylelint $(git ls-files "*.css")
eslint --max-warnings=0 --fix $(git ls-files "*.ts" "*.tsx" "*.js" | grep -v "lib/vscode")
stylelint $(git ls-files "*.css" | grep -v "lib/vscode")
tsc --noEmit
shellcheck -e SC2046,SC2164,SC2154,SC1091,SC1090,SC2002 $(git ls-files "*.sh")
shellcheck -e SC2046,SC2164,SC2154,SC1091,SC1090,SC2002 $(git ls-files "*.sh" | grep -v "lib/vscode")
if command -v helm && helm kubeval --help > /dev/null; then
helm kubeval ci/helm-chart
fi
Expand Down
14 changes: 7 additions & 7 deletions doc/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->
# Contributing

- [Pull Requests](#pull-requests)
- [Requirements](#requirements)
- [Development Workflow](#development-workflow)
- [Build](#build)
- [Structure](#structure)
- [Modifications to VS Code](#modifications-to-vs-code)
- [Currently Known Issues](#currently-known-issues)
- [Pull Requests](#pull-requests)
- [Requirements](#requirements)
- [Development Workflow](#development-workflow)
- [Build](#build)
- [Structure](#structure)
- [Modifications to VS Code](#modifications-to-vs-code)
- [Currently Known Issues](#currently-known-issues)

<!-- END doctoc generated TOC please keep comment here to allow auto update -->

Expand Down