-
Notifications
You must be signed in to change notification settings - Fork 5.9k
cli: add --home flag to customize "Go Home" button #2435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears my commit 5a38ab9 was a lie and never actually disabled the home button?
Would be good to revert that in this PR then.
Commit separation is really on point @jsjoeio |
If you go here, you can see where your changes (@nhooyr) were reverted: 0e7f504#diff-9e295724ddcc33de1e1e16290c98d43f43e5ce542612dd015d982853be82493cL3869-L3872 |
Documenting: @nhooyr hopped on a Zoom call with me. For whatever reason, it worked when he did it and pushed his commit 🤷♂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
f8c00e9
to
f941bec
Compare
f941bec
to
71abff7
Compare
For anyone who comes here later, the reason I had to force-push was because I had to create a GPG key to sign and verify my commits. The only way to sign old commits was to rebase and force-push. |
This PR introduces a new cli flag
--home
which allows the user to customize the "Go Home" button seen in the application menu.Changes
--home
as a valid CLI flag to configure link for "Go Home" buttonScreenshots
Checklist
Related
Fixes #2328