doc: Switch screenshot to use Chrome #2422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can see the difference live here: https://github.com/cdr/code-server/tree/ss-20c2 |
nhooyr
force-pushed
the
ss-20c2
branch
5 times, most recently
from
7b2091a to
0c9641c
Compare
nhooyr
changed the title
nhooyr
changed the title
Safari runs code-server horribly. We shouldn't even pretend that it sort of works. See the issues tagged browser-safari! Considered Firefox first but there's too many issues with it as well.
Not every PR needs our review. We get notified anyway as we're watching the repository.
oxy
reviewed
Dec 8, 2020
| @@ -1,3 +1 @@ | |||
| * @code-asher @nhooyr | |||
There was a problem hiding this comment.
Not sure if removing CODEOWNERS here was intentional!
There was a problem hiding this comment.
It was! We strive to break down each PR into individual commits. Makes it much easier to review. See the justification in the second commit.
Creating a new PR for every little change tends to get unwieldy.
There was a problem hiding this comment.
But yea know what actually, I'll try to do that from now on. It's def confusing to mesh things together in unrelated PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari runs code-server horribly. We shouldn't even pretend that it sort
of works.
See the issues tagged browser-safari!