Skip to content

media: Improve icon size #2401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ci/dev/gen_icons.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,11 @@ main() {

# -background defaults to white but we want it transparent.
# https://imagemagick.org/script/command-line-options.php#background
convert -background transparent -resize 256x256 favicon.svg favicon.ico
convert -background transparent -resize 192x192 favicon.svg pwa-icon-192.png
convert -background transparent -resize 512x512 favicon.svg pwa-icon-512.png
convert -quiet -background transparent -resize 256x256 favicon.svg favicon.ico
convert -quiet -background transparent -resize 192x192 pwa-icon.png pwa-icon-192.png
convert -quiet -background transparent -resize 512x512 pwa-icon.png pwa-icon-512.png

# We use -quiet above to avoid https://github.com/ImageMagick/ImageMagick/issues/884
}

main "$@"
Binary file modified src/browser/media/favicon.ico
Binary file not shown.
2 changes: 1 addition & 1 deletion src/browser/media/favicon.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/browser/media/pwa-icon-192.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/browser/media/pwa-icon-512.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/browser/media/pwa-icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.