Skip to content

vscode: Make eslint pass #2374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 30, 2020
Merged

vscode: Make eslint pass #2374

merged 3 commits into from
Nov 30, 2020

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Nov 27, 2020

Closes #2359

@nhooyr nhooyr requested a review from code-asher as a code owner November 27, 2020 13:20
@nhooyr nhooyr changed the title Lint vscode c2c2 vscode: Make eslint pass Nov 27, 2020
@nhooyr
ci: Enable vscode linting
5247878 
Updates #2359
@nhooyr
vscode: Make eslint pass
833314a 
I disabled code-layering and code-import-patterns as I don't think we
can make them easily pass as we reference all sorts of code from both
browser and node files. At least not worth the headache now to refactor
everything.
@nhooyr nhooyr modified the milestone: v3.7.4 Nov 30, 2020
@nhooyr nhooyr merged commit 0ad7d93 into master Nov 30, 2020
@nhooyr nhooyr deleted the lint-vscode-c2c2 branch November 30, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dooooofhgf dooooofhgf dooooofhgf approved these changes

@code-asher code-asher Awaiting requested review from code-asher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nhooyr @dooooofhgf