Dockerfile: include git #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should merge in everyone else's PRs instead so they get attribution. |
|
Mine (#230) does the same thing, except I put the git install in the wrong spot. |
Install git in the docker container, proposed by #203. While it is possible that issue requires further discussion, this is just a proposal pull request. If that proposal is accepted, here's the pull request.
|
@ammario the changes in this PR are different from the other PRs. Regardless, I've included all their commits here so they still get attribution and then included my own commit at the end to fix things up. |
ammario
requested changes
Mar 13, 2019
Dockerfile
Outdated
| @@ -1,6 +1,6 @@ | |||
| FROM node:8.15.0 | |||
|
|
|||
| # Install VS Code's deps. These are the only two it seems we need. | |||
| # Install VS Code's deps. These are the only two it seems we need. Install git for source control. | |||
There was a problem hiding this comment.
Second sentence is in the wrong place (and extraneous imo)
There was a problem hiding this comment.
I agree, from old a commit I just added. Will remove.
ammario
approved these changes
Mar 13, 2019
| net-tools \ | ||
| git \ | ||
| locales | ||
| RUN locale-gen en_US.UTF-8 |
There was a problem hiding this comment.
We could squash that into the other run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improves installation of runtime deps.
Closes #221
Closes #230
Closes #203