Move helm from root and fix stuff in README #2303
Conversation
nhooyr
force-pushed
the
helm-db7f
branch
2 times, most recently
from
ad3a370 to
ab9cd4d
Compare
ci/helm-chart/README.md
Outdated
| $ git clone https://github.com/cdr/code-server.git | ||
| $ helm install code-server/charts/code-server | ||
| $ git clone https://github.com/cdr/code-server | ||
| $ helm install code-server code-server/ci/helm-chart |
There was a problem hiding this comment.
what about just ci/helm the chart suffix seems implicit
There was a problem hiding this comment.
For me at least it helps to be clear that the directory itself is the chart. It's not like a bunch of scripts to generate the chart or anything.
There was a problem hiding this comment.
I agree, in most other repositories that maintain charts they are usual in a charts directory at the root, it's unusual for it to be called CI, it might be confusing since it's not build scripts or CI related wizardry.
There was a problem hiding this comment.
I agree, in most other repositories that maintain charts they are usual in a charts directory at the root, it's unusual for it to be called CI, it might be confusing since it's not build scripts or CI related wizardry.
At some point we will want to automate publishing the helm chart so it'll at least be somewhat used in CI.
We tend to keep all our release related stuff in the ci directory to prevent root pollution. In terms of discovery, I think the link I added in install.md should be enough.
| $ helm install --name my-release \ | ||
| --set persistence.enabled=false \ | ||
| deployment/chart | ||
| $ helm install code-server \ |
There was a problem hiding this comment.
we could potentially do helm upgrade --install to cover both install and upgrades
|
Moving this to v3.6.4 now, I don't think it's wise to merge as is. I'm not sure if this chart is for helm v2 or v3 now given the use of |
|
@nhooyr imo we should really only promote use of v3. Edit: to add to this the helm chart works fine with v3 |
|
Actually moved the release to tomorrow instead. |
|
@nhooyr this is a Helm v3 compatible chart. |
Absolutely! But since the examples use |
I used v3 to generate the template and cherry-picked the code-server related elements from the Helm Chart that was deprecated. |
|
Ok awesome! Then yea this should be good to go! |
Not sure where --name came from? Maybe an older version of helm. Ah, it's from v2.16.7
|
Awesome, thanks again @alexgorbatchev @Matthew-Beckett @sreya <3 |
See @sreya's review in #2048
Only thing I did not add is templating the mount directory but we can wait for someone else to contribute that at some point.
Also, I fixed the examples for helm v3 which does not have
--name.cc @alexgorbatchev @Matthew-Beckett