Fix self signed certificate for iPad #2255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhooyr
force-pushed
the
self-signed-3b2c
branch
2 times, most recently
from
7f6f2bb to
bd2d1b5
Compare
|
Second commit here is very juicy! |
nhooyr
force-pushed
the
self-signed-3b2c
branch
from
2c23441 to
3d37d2c
Compare
nhooyr
changed the title
nhooyr
force-pushed
the
self-signed-3b2c
branch
2 times, most recently
from
4b41f62 to
c8daba3
Compare
Now we add a subject alt name, set extendedKeyUsage and use the correct certificate extension. The above allow it to be properly trusted by iOS. See https://support.apple.com/en-us/HT210176 *.cert isn't a real extension for certificates, *.crt is correct for it to be recognized by e.g. keychain or when importing as a profile into iOS. Updates #1566 I've been able to successfully connect from my iPad Pro now to my code-server instance with a self signed certificate! Next commit will be docs.
Required for access under iPad.
nhooyr
force-pushed
the
self-signed-3b2c
branch
from
c8daba3 to
7a8ac87
Compare
code-asher
approved these changes
Nov 2, 2020
doc/ipad.md
Outdated
|
|
||
| The below assumes you are using the self signed certificate that code-server | ||
| generates for you. If not, that's fine but you'll have to make sure your certificate | ||
| abides by the following guidelines from apple: https://support.apple.com/en-us/HT210176 |
There was a problem hiding this comment.
Suggested change
| abides by the following guidelines from apple: https://support.apple.com/en-us/HT210176 | |
| abides by the following guidelines from Apple: https://support.apple.com/en-us/HT210176 |
nhooyr
force-pushed
the
self-signed-3b2c
branch
from
7a8ac87 to
c07296c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See composing commits.