Experimental initial connection fix #2250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhooyr
approved these changes
Oct 30, 2020
| @@ -1273,7 +1273,8 @@ index 0000000000000000000000000000000000000000..ab020fbb4e4ab3748cc807765ff9c362 | |||
| +// Wait for the init message then start up VS Code. Subsequent messages will | |||
| +// return new workbench options without starting a new instance. | |||
| +process.on('message', async (message: CodeServerMessage, socket) => { | |||
| + logger.debug('got message from code-server', field('message', message)); | |||
| + logger.debug('got message from code-server', field('type', message.type)); | |||
|
(We discussed a different approach on slack) |
code-asher
force-pushed
the
disconnects
branch
3 times, most recently
from
cde3054 to
64a0efb
Compare
This way the connection can be initiated by either side. It looks like sometimes the initial message from the client is lost (it never makes it into the onControlMessage callback) but I'm still not sure why or if that is preventable. Also added a timeout on the server end to clean things up in case the client never responds.
This will buffer any data sent to it until something is ready to listen on it.
code-asher
force-pushed
the
disconnects
branch
from
64a0efb to
9ad7d0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far the only way I've been able to reproduce the initial connection failure is to spawn 10+ tabs at a time. What I saw was that sometimes the initial message from the client doesn't make it to
onControlMessagecallback which causes the handshake to hang. I don't know yet why that is but for now I've made it so both ends will initiate the handshake so no matter what order or when they start listening everything should be fine.So far with this I haven't seen any connection failures due to incomplete handshakes (although when I spawn too many windows my browser seems to just not make websocket connections in the first place, but that results in different errors than the reported ones).