Skip to content

release-image: Remap UID within the image before handling $DOCKER_USER #2223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Oct 22, 2020

If do not update the UID within the passwd database to match whatever
uid the container is being ran as, then sudo will not work when renaming
the user to match $DOCKER_USER as it will complain about the current
user being non-existent.

Updates #2213

@nhooyr nhooyr requested a review from code-asher October 22, 2020 06:15
If do not update the UID within the passwd database to match whatever
uid the container is being ran as, then sudo will not work when renaming
the user to match $DOCKER_USER as it will complain about the current
user being non-existent.
@nhooyr nhooyr force-pushed the fix-uid-first-9602 branch from a8d8ba9 to bbae4a5 Compare October 22, 2020 06:16
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I ran with a custom UID and username with no problems.

@nhooyr nhooyr merged commit 79443c1 into master Oct 23, 2020
@nhooyr nhooyr deleted the fix-uid-first-9602 branch October 23, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants