doc: Simplify build process docs #2004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Much easier for users to use our CI scripts instead of each individual yarn step.
code-asher
reviewed
Aug 26, 2020
doc/CONTRIBUTING.md
Outdated
| @@ -49,12 +49,10 @@ reset VS Code then run `yarn vscode:patch`. | |||
|
|
|||
| ## Build | |||
|
|
|||
| The script we run in CI that does all the above | |||
There was a problem hiding this comment.
Does "all the above" refer to the development steps? Or should this say "below" in reference to the list of what it includes below?
There was a problem hiding this comment.
no sry this was just a brainfart lol.
code-asher
approved these changes
Aug 26, 2020
code-asher
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much easier for users to use our CI scripts instead of each individual
yarn step.