Allow opening files, folders, and workspaces in existing code-server from CLI

[shayne]

Add initial support for opening files / folders in running code-server instance.

Capabilities:

• Open an existing/new file(s) in running instance

$ code-server --reuse-window --open-in foo.txt
# or
$ code-server -oi foo.txt -r

• Open an existing folder in a new window

$ code-server --new-window --open-in path/to/project
# or
$ code-server -oi path/to/project -n

Current limitations:

• unable to open a file in a new window, only folders
• unable to use addMode feature
• others...

#164

[nhooyr]

I'm so sorry about this! Deleted the dev branch was gonna switch this back to base on master but GitHub doesn't let you do that.... After you delete the PR base.

🤦

Please open a new PR with these changes! Once again, I'm so sorry!

[nhooyr]

Nvm, got it!

[code-asher]

I gave it a test run and it works like a charm! Left a couple minor comments and am curious as to your thoughts on them.

[code-asher]

Awesome. It looks like the patch needs to be regenerated (to update the line number and hash) and I recently made a change to ipc.d.ts as well so we'll need to rebase or merge in master first before regenerating the patch (will need to update the vscode submodule as well since it's now on 1.48.2). Lemme know if you wanna handle that or if I should go ahead and do it (I think I'd need to create a new branch though since I can't push to yours).

[shayne]

the patch needs to be regenerated

Think I got it, let me know how the PR looks now

[code-asher]

Looks great! Thanks for the contribution. ❤️

[code-asher]

I think we can actually remove the open-in flag, lemme know if you think there could be any problems with that: #2013

[BEFH]

I'm getting this error:

[2022-07-06T17:18:23.749Z] error got error from Code {"error":{"errno":-2,"code":"ENOENT","syscall":"connect","address":"/hpc/users/fultob01/vsc_runtime/vscode-ipc-9ed54319-8737-41e7-a821-5ed74ba4a14c.sock"}}

Thoughts?

[jsjoeio]

@BEFH strange! Can you tell us more about your environment?

[code-asher]

Also, do you get that when running from within the integrated terminal or is it from an external terminal?

[BEFH]

@jsjoeio, what do you want to know about my environment? I can run commands and attach information.

I have installed code-server using anaconda and use fish as my shell. The server is running within a job on a centos 7 cluster with a bsub/lsf scheduler.

@code-asher, I am using the integrated terminal

[code-asher]

Huh, strange. VS Code is supposed to set the VSCODE_IPC_HOOK_CLI environment variable. Then when running code-server in the integrated terminal it is supposed to read that variable and write to the socket it contains.

Can you verify that VSCODE_IPC_HOOK_CLI is the same path as the path you get in the error? Possibly there is something wrong with that environment variable and code-server is using an old socket path or something.

[BEFH]

``` $ echo $VSCODE_IPC_HOOK_CLI /hpc/users/fultob01/vsc_runtime/vscode-ipc-ce1bb1ea-f88b-449b-8fbc-5169544ff4d9.sock $ code-server -r lsf.yaml [2022-07-21T00:56:42.371Z] error got error from Code {"error":{"errno":-2,"code":"ENOENT","syscall":"connect","address":"/hpc/users/fultob01/vsc_runtime/vscode-ipc-3d4badd4-9fa1-4f11-ab17-26ea33f5703f.sock"}} ``` I also ran the same command from the same node outside of vscode (after setting the VSCODE_IPC_HOOK_CLI variable), and I got the same error.

[code-asher]

Very strange that it is using the wrong path. The code seems to just use that as-is if it exists.

code-server/src/node/cli.ts

Lines 747 to 750 in 40b650b

	if (process.env.VSCODE_IPC_HOOK_CLI) {
	logger.debug("Found VSCODE_IPC_HOOK_CLI")
	return process.env.VSCODE_IPC_HOOK_CLI
	}

Could you run it with trace logging? code-server --log trace -r lsf.yaml