Add Nginx instructions to guide #1867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Nginx instructions for people who prefer to use this instead of Caddy
|
My reasoning to leave this out was that any user that can't setup Nginx without an example should be using Caddy instead. It's better on every front. |
|
cc @code-asher |
|
We've had so many issues filed from people just not understanding how to configure nginx. |
|
Yeah maybe it's worth having it just on account of all the issues. If so, we should add a trailing slash to the |
|
IMHO it never hurts to have too much documentation. Even if Caddy is good for 95% of the users, I think those 5% with existing nginx installs would appreciate it. I've added the trailing / now. |
code-asher
approved these changes
Jul 21, 2020
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Nginx instructions for people who prefer to use this instead of Caddy
See for example issue #770